Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common.shim): Enable metric tracking within external plugins #15636

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Wimmelwaldi
Copy link
Contributor

Summary

  • This PR enables external plugins to use metric tracking within their isolated environment

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15572

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 18, 2024
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Wimmelwaldi I assume you were able to test this and confirmed it resolved your request as well?

@powersj powersj self-assigned this Jul 18, 2024
@powersj
Copy link
Contributor

powersj commented Jul 23, 2024

@Wimmelwaldi could you confirm you were able to use the artifacts to resolve your issue?

@powersj powersj added the waiting for response waiting for response from contributor label Jul 23, 2024
@Wimmelwaldi
Copy link
Contributor Author

@powersj Sorry for the late reply. I was on vacation.

Yes, I can confirm that this has solved my issue.
I deliberately ignored inputs/shim here, as this is deprecated. If any parts of the code still have this dependency, they should rather be adapted.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Aug 5, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 5, 2024
@powersj powersj assigned DStrand1 and srebhan and unassigned powersj Aug 5, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with huge thank you @Wimmelwaldi!

@srebhan srebhan added the external plugin Plugins that would be ideal external plugin and expedite being able to use plugin w/ Telegraf label Aug 6, 2024
@srebhan srebhan merged commit fbac735 into influxdata:master Aug 6, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external plugin Plugins that would be ideal external plugin and expedite being able to use plugin w/ Telegraf feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric tracking within external plugins
4 participants