Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.remotefile): Add plugin to store metrics in remote files #15569

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 26, 2024

Summary

This new output plugin allows to write metrics to files in remote location such as AWS S3 providers or SFTP. Additionally, the plugin supports Golang templates for the files setting to allow generating the final filename from metric content.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15547

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 26, 2024
@srebhan srebhan mentioned this pull request Jun 26, 2024
@srebhan srebhan self-assigned this Jun 27, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 1, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jul 1, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty awesome! I have a few small questions inline.

go.mod Outdated Show resolved Hide resolved
plugins/outputs/remotefile/README.md Show resolved Hide resolved
plugins/outputs/remotefile/README.md Show resolved Hide resolved
plugins/outputs/remotefile/remotefile.go Show resolved Hide resolved
@srebhan srebhan requested a review from powersj July 8, 2024 15:33
@powersj powersj removed their assignment Jul 8, 2024
@DStrand1
Copy link
Member

DStrand1 commented Jul 9, 2024

@srebhan Could you rebase this PR to resolve the conflicts?

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Jul 9, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.80 % for linux amd64 (new size: 250.6 MB, nightly size 243.8 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit bcfd044 into influxdata:master Jul 10, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS S3 Output Plugin
4 participants