fix(inputs.chrony): Handle ServerStats4 response #15568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
srebhan
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks for caring for the chrony plugin @Frankkkkk! Much appreciated.
srebhan
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Thanks for caring for the chrony plugin @Frankkkkk! Much appreciated. Could you please run make tidy and push the changes so CI is happy!?
Chrony ≥ 4.4 introduces a new ServerStats response with u64 numbers and more fields. Fixes influxdata#15553 NB: The plugin still doesn't work due to influxdata#15549. To test this commit, please make sure you use influxdata#15552. Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu> Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
Frankkkkk
force-pushed
the
chrony-serverstats
branch
from
56c17a2
to
3745fd6
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
|
@srebhan Sorry for that! Fixed; thanks! |
srebhan
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks @Frankkkkk for taking care of the chrony plugin and your prompt responses! Much appreciated!
srebhan
added
the
ready for final review
powersj
approved these changes
Jun 27, 2024
srebhan
pushed a commit
that referenced
this pull request
Jul 1, 2024
(cherry picked from commit e2a8625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrony ≥ 4.4 introduces a new ServerStats response with u64 numbers and more fields.
Fixes #15553
NB: The plugin still doesn't work due to #15549. To test this commit, please make sure you use #15552.
Summary
Support chrony versions ≥ 4.4
Checklist
Related issues
resolves #15553