Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.azure_monitor): Add client options parameter #15519

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Jun 17, 2024

Summary

The PR adds the Azure Client option parameter to also support the Azure sovereign cloud regions.

Checklist

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 17, 2024
@ZPascal ZPascal marked this pull request as ready for review June 17, 2024 14:16
@ZPascal ZPascal force-pushed the adjust-the-azure-monitor branch 4 times, most recently from 923f63a to 8f1f3ba Compare August 5, 2024 19:23
@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 5, 2024

@srebhan & @powersj Can you please take a look?

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this upstream.

plugins/inputs/azure_monitor/README.md Outdated Show resolved Hide resolved
plugins/inputs/azure_monitor/azure_monitor.go Outdated Show resolved Hide resolved
@powersj powersj self-assigned this Aug 5, 2024
@ZPascal ZPascal requested a review from powersj August 5, 2024 21:55
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small item and then I can mark this ready for final review. Essentially, we watch the switch statement to throw an error if an unknown option value is recevied.

plugins/inputs/azure_monitor/azure_monitor.go Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 6, 2024
@powersj powersj assigned srebhan, dgnorton and DStrand1 and unassigned dgnorton and powersj Aug 6, 2024
@srebhan srebhan changed the title feat: Add the Azure client options parameter feat(inputs.azure_monitor): Add client options parameter Aug 7, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 7, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZPascal thanks for the PR! I do have just one small comment and a request to resolve the conflict...

plugins/inputs/azure_monitor/azure_monitor.go Outdated Show resolved Hide resolved
@srebhan srebhan added the area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor label Aug 7, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 7, 2024

@srebhan srebhan merged commit ad55f42 into influxdata:master Aug 7, 2024
27 checks passed
@ZPascal ZPascal deleted the adjust-the-azure-monitor branch August 7, 2024 19:52
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 7, 2024
@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 7, 2024

@srebhan Thanks for merging the PR. Will the feature be released with the next feature release in September?

@srebhan
Copy link
Member

srebhan commented Aug 8, 2024

@ZPascal very likely. You can see it is planned for v1.32.0 looking at the "Milestone" item in the PR. v1.32.0 is scheduled for 9th of September...

@ZPascal
Copy link
Contributor Author

ZPascal commented Aug 8, 2024

@srebhan Thank you for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants