-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.azure_monitor): Add client options parameter #15519
Conversation
923f63a
to
8f1f3ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this upstream.
8f1f3ba
to
aa796b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small item and then I can mark this ready for final review. Essentially, we watch the switch statement to throw an error if an unknown option value is recevied.
e23116d
to
14aa8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZPascal thanks for the PR! I do have just one small comment and a request to resolve the conflict...
a577b15
to
6ad4f7f
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@srebhan Thanks for merging the PR. Will the feature be released with the next feature release in September? |
@ZPascal very likely. You can see it is planned for v1.32.0 looking at the "Milestone" item in the PR. v1.32.0 is scheduled for 9th of September... |
@srebhan Thank you for the information. |
Summary
The PR adds the Azure Client option parameter to also support the Azure sovereign cloud regions.
Checklist