Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linters): Fix remaining errcheck warnings #15518

Merged
merged 13 commits into from
Jul 10, 2024
Merged

chore(linters): Fix remaining errcheck warnings #15518

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a329073
output plugins
DStrand1 Jun 13, 2024
a89eb6a
input plugins
DStrand1 Jun 14, 2024
be1c9b2
clean up golangci exclusions
DStrand1 Jun 14, 2024
8d4eb6c
fix missed platform specific files for linting
DStrand1 Jun 14, 2024
77a5756
fix remaining issues
DStrand1 Jun 25, 2024
66af08b
fix missed err removal
DStrand1 Jun 25, 2024
10283ec
fix another missed linux issue
DStrand1 Jun 25, 2024
a44af4a
fix more linux tests
DStrand1 Jun 26, 2024
a6b4c43
fix windows tests
DStrand1 Jun 26, 2024
3aa0265
reviews
DStrand1 Jun 27, 2024
0f2725e
Update plugins/inputs/amd_rocm_smi/amd_rocm_smi.go
DStrand1 Jun 27, 2024
669b645
reviews
DStrand1 Jul 2, 2024
8a9852d
review
DStrand1 Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up golangci exclusions
  • Loading branch information
@DStrand1
DStrand1 committed Jun 14, 2024
commit be1c9b2d5d70cd8c94a07914079ba28dc1f05180
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,6 @@ issues:
- package comment should be of the form "(.+)...
# EXC0015 revive: Annoying issue about not having a comment. The rare codebase has such comments
- should have a package comment
# nolintlint: directive `//nolint:errcheck` is unused for linter "errcheck"
# temporary while these are being fixed
- directive `//nolint:errcheck //.*` is unused for linter "errcheck"

# Excluding configuration per-path, per-linter, per-text and per-source
exclude-rules:
Expand Down
Loading