Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.ipmi_sensor): Collect additional commands #15495

Merged
merged 4 commits into from
Jun 18, 2024
Merged

feat(inputs.ipmi_sensor): Collect additional commands #15495

merged 4 commits into from
Jun 18, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 12, 2024

Summary

Introduces the ability to specify some additional sensor paths to collect. Specifically, dcmi power reading and chassis power status.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #1566

@powersj
feat(inputs.ipmi_sensor): Collect additional commands
9885bb5 
Introduces the ability to specify some additional sensor paths to
collect. Specifically, dcmi power reading and chassis power status.

fixes: influxdata#1566
@powersj powersj self-assigned this Jun 12, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 12, 2024
@powersj powersj mentioned this pull request Jun 12, 2024
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 13, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Jun 13, 2024
@srebhan
Copy link
Member

srebhan commented Jun 14, 2024

@powersj did you mean to convert it to a non-draft PR?

@powersj
Copy link
Contributor Author

powersj commented Jun 14, 2024

@powersj did you mean to convert it to a non-draft PR?

yes :) done

@powersj powersj marked this pull request as ready for review June 14, 2024 12:53
srebhan
srebhan reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Some comments from my side...

plugins/inputs/ipmi_sensor/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/ipmi_sensor/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/ipmi_sensor/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/ipmi_sensor/ipmi_sensor.go Outdated Show resolved Hide resolved
plugins/inputs/ipmi_sensor/ipmi_sensor.go Show resolved Hide resolved
plugins/inputs/ipmi_sensor/ipmi_sensor.go Show resolved Hide resolved
powersj and others added 3 commits June 17, 2024 09:36
@powersj @srebhan
Update plugins/inputs/ipmi_sensor/sample.conf
181af8d 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@powersj
clean up readme, shorten error
bfb1dd2
@powersj
remove header
7209dd2
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.58 % for linux amd64 (new size: 239.7 MB, nightly size 243.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan assigned DStrand1 and unassigned srebhan Jun 17, 2024
srebhan
srebhan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@DStrand1 DStrand1 merged commit 6fb4276 into influxdata:master Jun 18, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jun 18, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] ipmitool dcmi power reading
3 participants
@powersj @srebhan @DStrand1