-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.influxdb_v2): Preserve custom query parameters on write #15475
Conversation
This also speeds up the write path by building the non-changing parts of the "writeURL" once while still allowing for tag (or otherwise) defined destination buckets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice speedup and feature @glinton! I do have one comment in the code. Furthermore, could you please rebase this PR on the latest master to make tests pass!?
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @glinton!
Summary
Preserves any custom query parameters used in
URL
s in theinfluxdb_v2
output plugin.This also speeds up the write path by building the non-changing parts of the "writeURL" once while still allowing for tag (or otherwise) defined destination buckets.
Checklist
Related issues
resolves #15474