-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.openstack): Allow collection without admin privileges #15468
Conversation
@srebhan FYI I pushed a go mod tidy so you could get artifacts over night |
d83c15a
to
3f9c982
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
tested in a restricted OSP environment (no cluster admin permissions, just project admin) and it seems to work great:
used config (redacted):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly we still have no tests. I see that the reporter confirmed it works for his requested behavior, however it would be nice to know that this does not regress the current behavior as well.
Summary
Switch to gophercloud/v2 and simplify the code. This way, it becomes easier to use the plugin as non-admin and to maintain policies in OpenStack.
Checklist
Related issues
resolves #11769