Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.netflow): Add support for sFlow drop notification packets #15396

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented May 23, 2024

Summary

Add support for sFlow packets in format 5 denoting drop notification according to https://sflow.org/sflow_drops.txt.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15375

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 23, 2024
@srebhan srebhan marked this pull request as draft May 24, 2024 07:37
@srebhan srebhan added the upstream bug or issues that rely on dependency fixes label Jun 6, 2024
@srebhan srebhan marked this pull request as ready for review July 18, 2024 14:19
@srebhan
Copy link
Member Author

srebhan commented Jul 18, 2024

Now that upstream merged the required PRs netsampler/goflow2#328, netsampler/goflow2#336 and netsampler/goflow2#337, we can switch back to original package and define the PR as ready.

@srebhan srebhan added area/network New plugins or feature relating to Network Monitoring and removed upstream bug or issues that rely on dependency fixes labels Jul 18, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan
Copy link
Member Author

srebhan commented Jul 19, 2024

Marking this as ready due to enable a review as I'm pretty confident this is good due to a test case for the feature. However, I would feel even better if @akarneliuk could give this a final test...

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 19, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jul 19, 2024
@powersj powersj removed their assignment Jul 19, 2024
@DStrand1 DStrand1 merged commit afac9eb into influxdata:master Jul 19, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/network New plugins or feature relating to Network Monitoring feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support of SFlow drop packets
3 participants