-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.gnmi): Add option to create more descriptive tags #15278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Out of curiosity, do we need the full 28k line JSON file or could a more limited version be used?
Not necessarily. Should I shorten it? |
If it isn't straight forward, then we can keep as-is. |
@powersj shortened to ~1k lines... |
Fantastic, thank you very much! |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
While investigating an issue report I noticed that paths with multiple keys like
produce very bulky and undescriptive tags like
/openconfig-platform:components/component/subcomponents/subcomponent/name=PORT-1-1,name=LM-1
because key-keys are usually namedname
.The new
prefix_tag_key_with_path
would produce more descriptive tagscomponent_name=LM-1,subcomponent_name=PORT-1-1
by prefixing the key with the path segment containing the key.Checklist
Related issues