Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.http_listener_v2): Wrap timestamp parsing error messages #15239

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 26, 2024

Summary

When a timestamp fails to parse it produces a very vauge message:

2024-04-26T12:45:22Z E! [inputs.file] Error in plugin: could not parse "data": invalid number

This does not tell you what the data is, or even that it is the timestamp that failed to parse. Instead this PR changes to this:

2024-04-26T12:47:34Z E! [inputs.file] Error in plugin: could not parse "data": unable to parse timestamp "12a34567890": invalid number

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15237

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 26, 2024
@powersj powersj self-assigned this Apr 26, 2024
@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 26, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Apr 26, 2024
@DStrand1 DStrand1 removed their assignment Apr 26, 2024
@srebhan srebhan merged commit 1e5fdb6 into influxdata:master Apr 29, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone Apr 29, 2024
powersj added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.http_listener_v2: Even MORE debugging output
3 participants