Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): Use go's dependency checker for 'per platform' builds #15223

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(Makefile): Use go's dependency checker for 'per platform' builds #15223

merged 1 commit into from
Apr 25, 2024

Conversation

momoson
Copy link
Contributor

@momoson momoson commented Apr 25, 2024

Summary

In the telegraf building process make doesn't do any dependency checking as the process relies on the automatic dependency checking of go build. The package target previously used non-phony targets $(buildbin), whose recipe, due to the absence of prerequites, is not reexecuted if the $(buildbin) files exist. This PR fixes this issue by defining the $(buildbin) target as phony.

Checklist

  • No AI generated code was used in this PR

Related issues

Resolves #15222

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 25, 2024
@momoson
Copy link
Contributor Author

momoson commented Apr 25, 2024

!signed-cla

@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 25, 2024
@srebhan srebhan merged commit e3d2322 into influxdata:master Apr 25, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone Apr 25, 2024
@momoson momoson deleted the rebuild_packages_on_code_change branch April 25, 2024 20:45
powersj pushed a commit that referenced this pull request May 20, 2024
…15223)

Co-authored-by: Morian Sonnet <morian.sonnet@isea.rwth-aachen.de>
(cherry picked from commit e3d2322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make process does not rebuild "per platform" binaries
4 participants