-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.procstat): Report consistent I/O on Linux #15186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/procstat
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
labels
Apr 18, 2024
srebhan
changed the title
feat(inputs.procstat): Add fields for cached read/write bytes
fix(inputs.procstat): Report consistent I/O on Linux
Apr 19, 2024
srebhan
force-pushed
the
procstat_issue_9189
branch
from
April 19, 2024 16:01
b23b6dc
to
1969374
Compare
srebhan
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Apr 22, 2024
powersj
approved these changes
Apr 22, 2024
DStrand1
approved these changes
Apr 22, 2024
srebhan
changed the title
fix(inputs.procstat): Report consistent I/O on Linux
feat(inputs.procstat): Report consistent I/O on Linux
Apr 23, 2024
srebhan
force-pushed
the
procstat_issue_9189
branch
from
April 23, 2024 14:02
1969374
to
4ab2dd8
Compare
powersj
approved these changes
Apr 23, 2024
DStrand1
approved these changes
Apr 23, 2024
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/procstat
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fields
read_bytes
andwrite_bytes
do report the overall I/O including network etc on operating systems such as Windows. However on Linux, those two fields are filled by the I/O to the storage layer which causes inconsistent metrics across operating-systems.This PR changes the behavior on Linux and is now consistently reporting the overall I/O in
read_bytes
andwrite_bytes
(using therchar
andwchar
information). It furthermore reports the previous (storage-only I/O) via the newdisk_read_bytes
anddisk_write_bytes
fields.Checklist
Related issues
resolves #9189