-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.phpfpm): Check error before continue processing #15176
fix(inputs.phpfpm): Check error before continue processing #15176
Conversation
35085cc
to
673d82a
Compare
No problem. I've updated my PR to contains your fix (your commit, with check of errors done earlier) and include my test. |
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
673d82a
to
8874b2d
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the fix @PierreF!
(cherry picked from commit 31b2b50)
Summary
The PHP-FPM input could crash with a nil pointer dereferencing when timeout is used and the connect can't be established (e.g. the PHP-FPM server isn't running).
Checklist
Related issues
resolves #15175