fix(systemd): Remove 5 second timeout, use default (90) #15168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 5 second timeout was a little aggressive as a default value for users. Instead use the systemd default and/or let a user to set this to what they want. fixes: influxdata#15167
powersj
changed the title
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added
the
ready for final review
Hipska
approved these changes
Apr 16, 2024
srebhan
approved these changes
Apr 16, 2024
DStrand1
approved these changes
Apr 16, 2024
powersj
added a commit
that referenced
this pull request
Apr 22, 2024
(cherry picked from commit 406bd5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 5 second timeout was a little aggressive as a default value for users. Instead use the systemd default and/or let a user to set this to what they want.
Checklist
Related issues
fixes: #15167