Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.sqlserver): Add persistent version store metrics #15137

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

crenstrom
Copy link
Contributor

new measurement: sqlserver_persistent_version_store_stats

Summary

Accelerated Database Recovery (ADR) was added in SQL Server version 2019 and utilizes the Persistent Version Store to store data. Usage of the storage grows and shrinks with use. Monitoring the size and usage is helpful for understanding overall database size and use distribution, as well as identifying and troubleshooting ADR-related performance problems.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15136

new measurement sqlserver_persistent_version_store_stats
@telegraf-tiger telegraf-tiger bot added area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 10, 2024
@powersj
Copy link
Contributor

powersj commented Apr 10, 2024

@Trovalo any thoughts on this? Given it is protected by a version check I assume this is ok, but wanted your thoughts on the actual query and stats collected.

Thanks!

line formatting to reduce line length
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.88 % for linux amd64 (new size: 236.7 MB, nightly size 232.3 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@Trovalo
Copy link
Collaborator

Trovalo commented Apr 11, 2024

@Trovalo any thoughts on this? Given it is protected by a version check I assume this is ok, but wanted your thoughts on the actual query and stats collected.

Thanks!

I'll look into it today

Copy link
Collaborator

@Trovalo Trovalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine to me, even the naming convention is coherent with all the other queries.
I've never used ADR so I don't have an opinion on the metrics collected (but it's just plain numbers, nothing strange)

Thanks @crenstrom

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Trovalo for reviewing and @crenstrom for the time to put this up!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 11, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @crenstrom!

@srebhan srebhan merged commit 820d795 into influxdata:master Apr 11, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 11, 2024
@crenstrom crenstrom deleted the sqlserverPVS branch April 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics to monitor SQL Server Persistent Version Store (PVS) within Accelerated Database Recovery (ADR)
5 participants