-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sqlserver): Add persistent version store metrics #15137
Conversation
new measurement sqlserver_persistent_version_store_stats
@Trovalo any thoughts on this? Given it is protected by a version check I assume this is ok, but wanted your thoughts on the actual query and stats collected. Thanks! |
line formatting to reduce line length
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
I'll look into it today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems fine to me, even the naming convention is coherent with all the other queries.
I've never used ADR so I don't have an opinion on the metrics collected (but it's just plain numbers, nothing strange)
Thanks @crenstrom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Trovalo for reviewing and @crenstrom for the time to put this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @crenstrom!
new measurement: sqlserver_persistent_version_store_stats
Summary
Accelerated Database Recovery (ADR) was added in SQL Server version 2019 and utilizes the Persistent Version Store to store data. Usage of the storage grows and shrinks with use. Monitoring the size and usage is helpful for understanding overall database size and use distribution, as well as identifying and troubleshooting ADR-related performance problems.
Checklist
Related issues
resolves #15136