fix(inputs.prometheus): Remove duplicate response_timeout option #15078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In influxdata#14153, the HTTP client config struct gained a response timeout config option with TOML tags. This meant that there were two defined for both Prometheus plugin and the HTTP client config struct. This removes the one in Prometheus, which was used to set the one in the HTTP client anyway. fixes: influxdata#15076
telegraf-tiger
bot
added
area/prometheus
fix
|
Example output when set: With no value set or zero value: |
powersj
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Apr 8, 2024
DStrand1
approved these changes
Apr 9, 2024
powersj
added a commit
that referenced
this pull request
Apr 22, 2024
) (cherry picked from commit 47e28d0)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #14153, the HTTP client config struct gained a response timeout config option with TOML tags. This meant that there were two defined for both Prometheus plugin and the HTTP client config struct.
This removes the one in the Prometheus plugin, which allows users to correctly load previously existing plugins. However, the
response_timeoutoption will now set the HTTP Client config'sResponseHeaderTimeout, which is the time spent reading the headers of the response. Whiletimeoutwill set theTimeout, which sets the timeout for the entire connection.This would also get rid of the deprecation warning. Because this now sets a different value and there is no deprecation warning, I'm not sure this is the right thing to do, but it does allow a user to correctly load a config. The other option may be not to import HTTPClientConfig and have that locally?
Checklist
Related issues
fixes: #15076