Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.kubernetes): Add option to node metric name #15049

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat(inputs.kubernetes): Add option to node metric name #15049

merged 1 commit into from
Mar 25, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 22, 2024

Summary

The k8s and kube_node plugins produce the same metric name that can conflict. Provide an option in the k8s plugin to change the name.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #9451

@powersj
feat(inputs.kubernetes): Add option to node metric name
fc872ad 
The k8s and kube_node plugins produce the same metric name that can
conflict. Provide an option in the k8s plugin to change the name.

fixes: influxdata#9451
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 22, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 22, 2024
@DStrand1 DStrand1 removed their assignment Mar 22, 2024
@srebhan srebhan merged commit 6e8e7e5 into influxdata:master Mar 25, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 25, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

Rename kubernetes_node measurements in inputs.kube_inventory or inputs.kubernetes
3 participants
@powersj @srebhan @DStrand1