feat(snmp): Add secret support for auth_password and priv_password #14975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
srebhan
added
area/snmp
plugin/input
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
|
Hi, it is not really working. This is my telegraf.conf with the secrets config (this one is working fine with "<< token = "@{localsecrets:influxdb_token}" >>"for influx): [[secretstores.jose]]
id = "localsecrets"
path = "/etc/telegraf/secrets"
password = "xxxx"$ telegraf secrets list
Known secrets for store "localsecrets":
influxdb_token
snmpv3_operator_token
snmpv3_token [[inputs.snmp]]
...
auth_protocol = "SHA"
auth_password = "@{localsecrets:snmpv3_token}"
priv_protocol = "AES"
priv_password = "@{localsecrets:snmpv3_token}"$telegraf --test --config /etc/telegraf/telegraf.d/snmp.conf.test
2024-03-12T12:52:16Z I! Loading config: /etc/telegraf/telegraf.d/snmp.conf.test
2024-03-12T12:52:16Z E! unknown secret-store for "@{localsecrets:snmpv3_token}" |
|
Ignore the above ... It is working fine, I forgot to add the telegraf config (where the secretstore is defined) in the test $telegraf --test --config /etc/telegraf/telegraf.conf --config /etc/telegraf/telegraf.d/snmp.conf.test |
powersj
approved these changes
Mar 12, 2024
DStrand1
approved these changes
Mar 13, 2024
Hipska
reviewed
Apr 23, 2024
| if !s.PrivPassword.Empty() { | ||
| p, err := s.PrivPassword.Get() | ||
| if err != nil { | ||
| return GosnmpWrapper{}, fmt.Errorf("getting private password failed: %w", err) |
There was a problem hiding this comment.
- return GosnmpWrapper{}, fmt.Errorf("getting private password failed: %w", err)
+ return GosnmpWrapper{}, fmt.Errorf("getting privacy password failed: %w", err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for secrets to all SNMP-family plugins.
Checklist
Related issues
resolves #14972