Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.knx_listener): Reconnect after connection loss #14959

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 11, 2024

Summary

If the connection to the router or tunnel device is lost for whatever reason, the plugin will make no attempt to reconnect and is thus left dysfunctional. This PR adds a retry logic triggered in every gather cycle to reconnect the plugin.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14695

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 11, 2024
@srebhan srebhan added the area/iot New plugins or features relating to IoT monitoring label Mar 11, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 11, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Mar 11, 2024
@DStrand1 DStrand1 removed their assignment Mar 11, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, but would like to hear back from Alexander in the original issue first. If I see confirmation, I'll land.

@powersj powersj merged commit 6afa18f into influxdata:master Mar 18, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.1 milestone Mar 18, 2024
powersj pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/iot New plugins or features relating to IoT monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KNX Listener stops receiving messages
3 participants