-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.docker_log): Use correct name when matching containers #14874
Conversation
Copied the fix from docker.go file.
Thanks so much for the pull request! |
!signed-cla |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @Kunnik!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break existing user's tags right? I think we should call this out in the readme as well. @srebhan thoughts?
@powersj I think it will filter out some instances that were output before. If you for example had two containers |
Yeap, as was said in the issue I posted in the summary, docker sometimes report more container names for the one container in weird format "/container1/container2". At least in our case, there is always correct container name next to this complicated names in the array. |
Copied the fix from docker.go file.
Summary
This fix should change how docker logs plugin searches for the correct container name.
We found out that there was similar fix done in docker plugin few years ago.
#4376
Checklist
Related issues
resolves #