Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.phpfpm): Continue despite erroneous sockets #14852

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 20, 2024

Summary

Currently, the plugin does not gather any data if a single socket cannot be connected. This PR changes the behavior to collect all available data and output the errors for the other ones.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14261

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 20, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 21, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj removed their assignment Feb 21, 2024
@DStrand1 DStrand1 merged commit c475771 into influxdata:master Feb 21, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.phpfpm exit if unix socket doesn't exist
3 participants