Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common.opcua): Add debug info for nodes not in server namespace #14676

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

caallinson
Copy link
Contributor

@caallinson caallinson commented Feb 2, 2024

Summary

Add Debug logging of node name and identifier for nodes that are not in OPC-UA server namespace

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14675

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 2, 2024
@srebhan srebhan self-assigned this Feb 5, 2024
@srebhan srebhan changed the title feat(opcua, opcua_listener): Log info for nodes not in server namespace to Debug feat(opcua): Log info for nodes not in server namespace to Debug Feb 5, 2024
@srebhan srebhan changed the title feat(opcua): Log info for nodes not in server namespace to Debug feat(common.opcua): Add debug info for nodes not in server namespace Feb 5, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @caallinson! Just two small comments from my side...

plugins/common/opcua/input/input_client.go Outdated Show resolved Hide resolved
plugins/inputs/opcua_listener/subscribe_client.go Outdated Show resolved Hide resolved
@caallinson
Copy link
Contributor Author

@srebhan complete

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @caallinson!

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 6, 2024
@srebhan srebhan assigned powersj and unassigned srebhan Feb 6, 2024
@powersj powersj merged commit c981bb7 into influxdata:master Feb 6, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opcua feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPC UA - Log Node and Identifier to debug for items not in server namespace
3 participants