-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.snmp_trap): Enable SHA ciphers #14665
Conversation
Hi, Thanks for the issue and PR. Can you pleaes:
Thanks! |
Updated sample.conf and ran make docs to update the README.md to match I verified the PR using our SNMP4J-based traffic generator to send events through Telegraf and verified the content of the events using Wireshark, output from Telegraf contained the original data unchanged. I manually tested the following combinations with AES256: SHA224, SHA256, SHA384 and SHA512. The code already had unit tests to cover the SHA ciphers so I just needed to take them into use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @JuhaKS!
(cherry picked from commit f9f2adf)
Summary
SHA224, SHA256, SHA384 and SHA512 ciphers had been commented out when SNMPv3 support was implemented because they were not at that time yet sufficiently supported by gosnmp. Gosnmp has advanced and the ciphers are now fully working, so they can be added to the list of valid options for the snmp_trap plugin
Checklist
Related issues
resolves #14664