Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.redfish): Resolve iLO4 fan data #14659

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 31, 2024

Summary

HP's iLO 4 was released before redfish support as present. They have added compatibility along the way and we carry a change to add a header to ensure this compatibility occurs. However, this header is not always needed and explains why iLO 4 devices were not returning fan data.

User's of iLO 4, which we have no way of knowing, will need to enable this workaround to get fan data.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14488

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 31, 2024
@powersj powersj self-assigned this Jan 31, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 31, 2024
@powersj powersj marked this pull request as ready for review January 31, 2024 20:58
@powersj powersj assigned srebhan and unassigned powersj Jan 31, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.44 % for linux amd64 (new size: 224.7 MB, nightly size 221.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @powersj!

@srebhan srebhan merged commit d8dc29b into influxdata:master Feb 1, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 1, 2024
powersj added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inputs.redfish says it reports fans. That does not seem to be the case with ILO4
2 participants