Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.vsphere): Use guest.guestId value if set for guest name #14635

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 29, 2024

Summary

If the guest.guestId value is set, use this as it can be more up to date given this value is from the guest tools.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #14616

@telegraf-tiger telegraf-tiger bot added area/vsphere fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 29, 2024
@powersj powersj self-assigned this Jan 29, 2024
@powersj powersj marked this pull request as ready for review February 1, 2024 14:37
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 1, 2024
@powersj powersj assigned srebhan and unassigned powersj Feb 1, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit a0f239c into influxdata:master Feb 1, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 1, 2024
powersj added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
2 participants