Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal.snmp): Rephrase error message is about translating OID #14612

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

senpro-ingwersenk
Copy link
Contributor

Summary

This addresses #14598 and #10444
The previous error message was unclear, especially to newcommers to SNMP, SMI and MIBs. With this slight rephrasing, users may have a better clue as to what the issue might be and can start looking for issues approprietly.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14598 and #10444 - at least partially.

This addresses influxdata#14598 and influxdata#10444 
The previous error message was unclear, especially to newcommers to SNMP, SMI and MIBs. With this slight rephrasing, users may have a better clue as to what the issue might be and can start looking for issues approprietly.
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@senpro-ingwersenk
Copy link
Contributor Author

!signed-cla

@telegraf-tiger
Copy link
Contributor

@powersj powersj changed the title Rewrite error message in internal/snmp/translate.go fix(snmp): Rephrase error message is about translating OID Jan 23, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 23, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better. Thanks @senpro-ingwersenk!

@srebhan srebhan added fix pr to fix corresponding bug chore and removed chore fix pr to fix corresponding bug labels Jan 23, 2024
@srebhan srebhan changed the title fix(snmp): Rephrase error message is about translating OID chore(internal.snmp): Rephrase error message is about translating OID Jan 23, 2024
@srebhan srebhan merged commit 9878eba into influxdata:master Jan 23, 2024
25 of 28 checks passed
@github-actions github-actions bot added this to the v1.29.3 milestone Jan 23, 2024
powersj pushed a commit that referenced this pull request Jan 29, 2024
hhiroshell pushed a commit to hhiroshell/telegraf that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP/gosmi: Counter32 not supported, potentially.
4 participants