Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(processors.filter): Convert noop processor to filter processor #14330

Merged
merged 11 commits into from
Nov 27, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Nov 21, 2023

This converts the newly added noop processor to a actual filter as the functionality of the noop can already be achieved using the override counterpart.

plugins/processors/filter/README.md Outdated Show resolved Hide resolved
plugins/processors/filter/README.md Outdated Show resolved Hide resolved
plugins/processors/filter/sample.conf Outdated Show resolved Hide resolved
srebhan and others added 3 commits November 21, 2023 18:31
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
@srebhan srebhan requested a review from Hipska November 22, 2023 11:47
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 23, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, like this a lot better.

@powersj powersj merged commit 1c2c03d into influxdata:master Nov 27, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants