-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(outputs.kafka): Use private network for testing #14220
Conversation
This ensures the kafka output integration test will use a private network when running tests. This ensures that the default port, 9092, is available for testing by the kafka container.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @powersj! Let's hope that was the last issue for this test. ;-)
…nmp_lookup * upstream/master: chore(linters): Fix findings found by testifylint: expected-actual (influxdata#14229) chore(deps): Bump github.com/nats-io/nkeys from 0.4.5 to 0.4.6 (influxdata#14225) feat(inputs.procstat)!: Remove useless zero cpu_times (influxdata#14224) feat(inputs.gnmi): Rework plugin (influxdata#14091) fix(outputs.timestream): Clip uint64 values (influxdata#14213) fix(inputs.cgroup): Escape backslashes (influxdata#14187) test(outputs.kafka): Use private network for testing (influxdata#14220) test(inputs.vault): Fix integration test by only testing for subset (influxdata#14222) fix(outputs.elasticsearch): Print error status value (influxdata#14115)
(cherry picked from commit 8c35ddd)
This ensures the kafka output integration test will use a private network when running tests. This ensures that the default port, 9092, is available for testing by the kafka container.