Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(outputs.kafka): Use private network for testing #14220

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Oct 31, 2023

This ensures the kafka output integration test will use a private network when running tests. This ensures that the default port, 9092, is available for testing by the kafka container.

This ensures the kafka output integration test will use a private
network when running tests. This ensures that the default port, 9092, is
available for testing by the kafka container.
@telegraf-tiger telegraf-tiger bot added area/kafka plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins test labels Oct 31, 2023
@powersj powersj marked this pull request as ready for review October 31, 2023 15:36
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 31, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Let's hope that was the last issue for this test. ;-)

@srebhan srebhan merged commit 8c35ddd into influxdata:master Oct 31, 2023
23 checks passed
@github-actions github-actions bot added this to the v1.28.4 milestone Oct 31, 2023
Hipska added a commit to Super-Visions/telegraf that referenced this pull request Nov 2, 2023
…nmp_lookup

* upstream/master:
  chore(linters): Fix findings found by testifylint: expected-actual (influxdata#14229)
  chore(deps): Bump github.com/nats-io/nkeys from 0.4.5 to 0.4.6 (influxdata#14225)
  feat(inputs.procstat)!: Remove useless zero cpu_times (influxdata#14224)
  feat(inputs.gnmi): Rework plugin (influxdata#14091)
  fix(outputs.timestream): Clip uint64 values (influxdata#14213)
  fix(inputs.cgroup): Escape backslashes (influxdata#14187)
  test(outputs.kafka): Use private network for testing (influxdata#14220)
  test(inputs.vault): Fix integration test by only testing for subset (influxdata#14222)
  fix(outputs.elasticsearch): Print error status value (influxdata#14115)
powersj added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants