Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve behavior documentation of metricpass #13883

Merged
merged 3 commits into from
Sep 7, 2023
Merged

docs: Improve behavior documentation of metricpass #13883

merged 3 commits into from
Sep 7, 2023

Conversation

knollet
Copy link
Contributor

@knollet knollet commented Sep 7, 2023 •
edited by srebhan
Loading

Add note about failing metricpass expressions being valued as true

resolves #13815

@telegraf-tiger telegraf-tiger bot added the docs Issues related to Telegraf documentation and configuration descriptions label Sep 7, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 7, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.01 % for linux amd64 (new size: 197.0 MB, nightly size 195.0 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@knollet knollet mentioned this pull request Sep 7, 2023
Closed
@srebhan srebhan changed the title docs: added note about failing metricpass expressions being v… docs: Improve behavior documentation of metricpass Sep 7, 2023
srebhan
srebhan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @knollet!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 7, 2023
powersj
powersj reviewed Sep 7, 2023
View reviewed changes
docs/CONFIGURATION.md Outdated Show resolved Hide resolved
@powersj powersj merged commit 7fe6bb3 into influxdata:master Sep 7, 2023
@powersj
Copy link
Contributor

powersj commented Sep 7, 2023

Thanks for the observation and PR. I did make a couple changes

@github-actions github-actions bot added this to the v1.28.0 milestone Sep 7, 2023
athornton pushed a commit to lsst-sqre/telegraf that referenced this pull request Sep 8, 2023
@knollet @athornton
docs: Improve behavior documentation of metricpass (influxdata#13883)
5ae7173
@knollet knollet deleted the doc_failing_metricpass_is_true branch September 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
docs Issues related to Telegraf documentation and configuration descriptions ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

metricpass returns True on error
3 participants
@knollet @powersj @srebhan