Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable filepathJoin checker for gocritic #13758

Merged
merged 2 commits into from
Aug 14, 2023
Merged

chore: Enable filepathJoin checker for gocritic #13758

merged 2 commits into from
Aug 14, 2023

Conversation

zak-pawel
Copy link
Collaborator

resolves #13193

@telegraf-tiger telegraf-tiger bot added the chore label Aug 13, 2023
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 14, 2023
srebhan
srebhan approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @zak-pawel!

@srebhan srebhan merged commit 5661341 into influxdata:master Aug 14, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.27.4 milestone Aug 14, 2023
@Hipska
Copy link
Contributor

Hipska commented Aug 16, 2023

image

powersj pushed a commit that referenced this pull request Aug 21, 2023
@zak-pawel @powersj
chore: Enable filepathJoin checker for gocritic (#13758)
83e4344 
Co-authored-by: Pawel Zak <Pawel Zak>
(cherry picked from commit 5661341)
@zak-pawel zak-pawel mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

@Hipska Hipska Awaiting requested review from Hipska

Assignees

@srebhan srebhan

Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.4
Development

Successfully merging this pull request may close these issues.

gocritic->filepathJoin - Detects problems in filepath.Join() function calls. Should we enable it?
4 participants
@zak-pawel @Hipska @powersj @srebhan