-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update removal and deprecations for v1.30.0 #13351
Conversation
This updates the various locations that v2.0.0 is used as the removal date for telegraf. As we are not doing a v2.0.0 anymore, we still want to remove many long standing items. Using the v1.30 release is a good, round number to make that happen and this gives folks more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking through those! Do we also want to deprecate outputs.riemann_legacy
?
yes - thank you for catching this. PR updated edit: also thank you for filing the issues, I've updated #13376 with riemann_legacy |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through the plugins!
There are a lot more deprecated plugin options, and those don't have mentioned hard coded 2.0 removal, will still say they will be removed in that version. Shouldn't those get a hard-coded version of 1.30 as well? |
@Hipska we decided to remove the options that are ignored by now anyway. For everything else we do have no way to help the user converting the configs (read: we do not have migrations). Therefore, for now we started out with the deprecated plugins (and hope to have migrations out till then) and options that are not used anyway. Does that make sense? |
There are more options that are ignored but were deprecated after 1.0 release. Those don't have a fixed removal version and dus claim to be removed in 2.0 (next major). It looks like this PR only addressed options that got deprecated in 0.xx versions. It surely makes sense, but it simply doesn't seem complete.. |
@Hipska let's try this first before doing big changes that we then need to revert... |
If it is only about removing options that were ignored/unused anyway, what could be the problem with that? |
This updates the various locations that v2.0.0 is used as the removal date for telegraf. As we are not doing a v2.0.0 anymore, we still want to remove many long-standing items. Using the v1.30 release is a good, round number to make that happen and this gives folks more time.
The removal of netsnmp, in favor of gosmi was not updated in config/config.go, line 530. I thought we should talk about that one first.