Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update removal and deprecations for v1.30.0 #13351

Merged
merged 8 commits into from
Jun 2, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 26, 2023

This updates the various locations that v2.0.0 is used as the removal date for telegraf. As we are not doing a v2.0.0 anymore, we still want to remove many long-standing items. Using the v1.30 release is a good, round number to make that happen and this gives folks more time.

The removal of netsnmp, in favor of gosmi was not updated in config/config.go, line 530. I thought we should talk about that one first.

This updates the various locations that v2.0.0 is used as the removal
date for telegraf. As we are not doing a v2.0.0 anymore, we still want
to remove many long standing items. Using the v1.30 release is a
good, round number to make that happen and this gives folks more time.
@telegraf-tiger telegraf-tiger bot added the chore label May 26, 2023
plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
plugins/inputs/icinga2/icinga2.go Outdated Show resolved Hide resolved
plugins/parsers/xpath/parser.go Outdated Show resolved Hide resolved
plugins/parsers/xpath/parser.go Outdated Show resolved Hide resolved
plugins/parsers/xpath/parser.go Outdated Show resolved Hide resolved
plugins/parsers/xpath/parser.go Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 31, 2023
@powersj powersj marked this pull request as ready for review May 31, 2023 20:28
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking through those! Do we also want to deprecate outputs.riemann_legacy?

@powersj
Copy link
Contributor Author

powersj commented Jun 1, 2023

Thanks for looking through those! Do we also want to deprecate outputs.riemann_legacy?

yes - thank you for catching this. PR updated

edit: also thank you for filing the issues, I've updated #13376 with riemann_legacy

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 1, 2023

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through the plugins!

@srebhan srebhan merged commit ca7c8f7 into influxdata:master Jun 2, 2023
@Hipska
Copy link
Contributor

Hipska commented Jun 13, 2023

There are a lot more deprecated plugin options, and those don't have mentioned hard coded 2.0 removal, will still say they will be removed in that version. Shouldn't those get a hard-coded version of 1.30 as well?

@srebhan
Copy link
Member

srebhan commented Jun 14, 2023

@Hipska we decided to remove the options that are ignored by now anyway. For everything else we do have no way to help the user converting the configs (read: we do not have migrations). Therefore, for now we started out with the deprecated plugins (and hope to have migrations out till then) and options that are not used anyway. Does that make sense?

@Hipska
Copy link
Contributor

Hipska commented Jun 15, 2023

There are more options that are ignored but were deprecated after 1.0 release. Those don't have a fixed removal version and dus claim to be removed in 2.0 (next major). It looks like this PR only addressed options that got deprecated in 0.xx versions.

It surely makes sense, but it simply doesn't seem complete..

@srebhan
Copy link
Member

srebhan commented Jun 15, 2023

@Hipska let's try this first before doing big changes that we then need to revert...

@Hipska
Copy link
Contributor

Hipska commented Jun 16, 2023

If it is only about removing options that were ignored/unused anyway, what could be the problem with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants