-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable G103 rule for gosec #13038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to Thomas' questions, I had one about how we document this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel for looking at this and also for fixing some of the locations. Maybe I'm just misreading the comments, but to me
//nolint:gosec // G103: Use of unsafe calls should be audited
reads like "we will check this later". If this is the actual meaning I want to veto this as nobody will ever look for those again once silenced. If the meaning is "I checked and it is a valid use" we should state that explicitly IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for making the comment more clear @zak-pawel!
@powersj are you OK with the new wording?
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
(cherry picked from commit 55e4bb6)
resolves #12891