Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable G301, G302 and G306 rules for gosec #13022

Merged
merged 3 commits into from
Apr 4, 2023
Merged

chore: Enable G301, G302 and G306 rules for gosec #13022

merged 3 commits into from
Apr 4, 2023

Conversation

zak-pawel
Copy link
Collaborator

resolves #12940
resolves #12941
resolves #12945

@telegraf-tiger telegraf-tiger bot added the chore label Apr 3, 2023
@zak-pawel zak-pawel mentioned this pull request Apr 3, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 3, 2023
srebhan
srebhan approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @zak-pawel!

@srebhan
Copy link
Member

srebhan commented Apr 4, 2023

@zak-pawel please resolve the conflict.

@powersj
Copy link
Contributor

powersj commented Apr 4, 2023

I tried resolving the conflict, will look once tests hopefully pass.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Apr 4, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 89fa07f into influxdata:master Apr 4, 2023
powersj pushed a commit that referenced this pull request Apr 24, 2023
@zak-pawel @powersj
chore: Enable G301, G302 and G306 rules for gosec (#13022)
f5a9b73 
(cherry picked from commit 89fa07f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
3 participants
@zak-pawel @srebhan @powersj