fix(outputs.wavefront): update wavefront sdk and use non-deprecated APIs

[LukeWinikates]

Required for all PRs

• Updated associated README.md.
• Wrote appropriate unit tests.
• Pull request title or commits are in conventional commit format

The Wavefront output plugin uses APIs from the Wavefront Go SDK that have been deprecated. This PR updates the SDK version and adopts the currently recommended APIs for configuring the Wavefront sender.

[powersj]

Thank you for taking the time to put up this PR!

[srebhan]

Thanks @LukeWinikates for the fix. The code looks good, I only would like to see the two new functions to not be exported. Can you please change this?

[LukeWinikates]

@srebhan

I've learned a couple of things about the wavefront SDK deprecations. It might make sense to open an issue for discussing.

It turns out that you can't create a TCP connection in the Wavefront Go SDK unless you use the NewProxySender function, which is one of the deprecated ones. The Wavefront SDK has not just deprecated the old constructors, it has deprecated TCP.

Unfortunately that means my PR needs to be updated, and we have to choose between continuing to use the deprecated functions and introducing a behavior change.

I wonder if folks actually successfully use the TCP connection for the Wavefront output plugin. When my team first tried it, we found that it eventually dies silently because of socket timeouts. #7160 describes the same scenario. For that reason, we've always used the http connection.

I can see a few different options here:

One is to close this PR, and keep using the deprecated APIs

Another would be to make the host/port config style return an http sender, instead of a tcp one. Maybe print a warning about using these fields, and encourage people to switch to the url field.

I'm going to update this PR to follow the latter path - I'd love to know what y'all think would be best here.

[LukeWinikates]

Pushing what I have at the moment - I will also make some documentation updates tomorrow.

[srebhan]

Looks good to me. Thanks @LukeWinikates for the fix!

Regarding the usage of deprecated functions vs. removal of TCP... I'd say let's first merge this PR as it is better than nothing. Then open an issue and we can discuss on how to handle the issue. It would be nice to know the timeframe for the removal of deprecated functions, maybe we need a new version of the plugin... But let's discuss this in the issue.

[LukeWinikates]

Thanks @srebhan & @powersj -- the readme is now updated as well, so hopefully that's everything that this PR needs. I appreciate your feedback!

[srebhan]

For the deprecation, can you please annotate the options similar to StringToNumber so that users get a nice deprecation warning when running Telegraf!?

[powersj]

Thanks again for driving these changes!

[srebhan]

@LukeWinikates can you please rebase your PR on the latest master to solve the merge conflicts!?

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz