Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added metrics for member and replica-set avg health of MongoDB … #11516

Merged
merged 3 commits into from
Jul 20, 2022
Merged

feat: added metrics for member and replica-set avg health of MongoDB … #11516

merged 3 commits into from
Jul 20, 2022

Conversation

svenburkard
Copy link
Contributor

…input plugin

  • make check
  • make check-deps
  • make test
  • make docs
  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format

resolves #11515

Added metrics for member and replica-set average health of MongoDB input plugin.
With this additional Telegraf metrics, you have all needed data ready to build monitoring alerts on unhealthy MongoDB replica-set events.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 18, 2022
srebhan
srebhan reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @svenburkard, thanks for your contribution. The code looks quite nice already, I only have two minor comments. Please have a look!

plugins/inputs/mongodb/mongostat.go Outdated Show resolved Hide resolved
plugins/inputs/nats_consumer/README.md Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Jul 19, 2022
@srebhan srebhan added area/mongodb plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 19, 2022
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@svenburkard
Copy link
Contributor Author

Hi @srebhan, thanks for your feedback. The suggested changes have been added with a fresh rebase of the current master and the Lint CI job seems to be happy now :)

srebhan
srebhan approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution @svenburkard!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 20, 2022
@svenburkard
Copy link
Contributor Author

Nice, you are welcome!

@powersj powersj merged commit 46f059e into influxdata:master Jul 20, 2022
@sjwang90 sjwang90 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inputs.mongodb : adding metrics for member and replica-set avg health
3 participants
@svenburkard @powersj @srebhan