fix: rename consul_metrics -> consul agent #10876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
The term metrics is somewhat redundent and the difference between the two consul plugins not entirely clear. While it might be nice to rename the original consul plugin to consul_services or something similar, we can only rename the yet unreleaesd consul_metrics plugin.
powersj
force-pushed
the
rename-consul-agent
branch
from
f0dd331
to
fce85ec
Compare
MyaLongmire
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term metrics are somewhat redundant and the difference between the
two consul plugins is not entirely clear. While it might be nice to rename
the original consul plugin to consul_services or something similar, we
can only rename the yet unreleased consul_metrics plugin.