Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (outputs.elasticsearch) Add healthcheck timeout #10853

Merged
merged 4 commits into from
Mar 30, 2022
Merged

feat: (outputs.elasticsearch) Add healthcheck timeout #10853

merged 4 commits into from
Mar 30, 2022

Conversation

aratik711
Copy link
Contributor

Required for all PRs:

resolves #10852

The changes are listed below:

  • Added healthcheck timeout for ES client: SetHealthcheckTimeout, setting the default healthcheck timeout to 1s

@aratik711 aratik711 changed the title feat[elastic output]: add healthcheck timeout for ES feat: [elastic output] add healthcheck timeout for ES Mar 19, 2022
@sspaink sspaink changed the title feat: [elastic output] add healthcheck timeout for ES feat(outputs.elasticsearch): Add healthcheck timeout Mar 21, 2022
MyaLongmire
MyaLongmire suggested changes Mar 21, 2022
View reviewed changes
plugins/outputs/elasticsearch/README.md Outdated Show resolved Hide resolved
plugins/outputs/elasticsearch/elasticsearch.go Outdated Show resolved Hide resolved
@aratik711 aratik711 changed the title feat(outputs.elasticsearch): Add healthcheck timeout feat: (outputs.elasticsearch) Add healthcheck timeout Mar 22, 2022
@aratik711
Copy link
Contributor Author

@MyaLongmire done, Please review

MyaLongmire
MyaLongmire approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) Thanks for adding this!

@Hipska Hipska added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/elasticsearch ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Mar 23, 2022
reimda
reimda suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the sample config comment it looks good to me. Thanks!

plugins/outputs/elasticsearch/elasticsearch.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@aratik711
Copy link
Contributor Author

@reimda updated, please check

@reimda
Copy link
Contributor

reimda commented Mar 30, 2022

Thanks, Arati!

@reimda reimda merged commit 6a0311c into influxdata:master Mar 30, 2022
@sjwang90 sjwang90 mentioned this pull request Jun 9, 2022
Closed
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
@aratik711 @MyaLongmire
feat: (outputs.elasticsearch) Add healthcheck timeout (#10853)
006dda3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@reimda reimda reimda approved these changes

@Hipska Hipska Hipska approved these changes

Assignees
No one assigned
Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch Output plugin add timeout for healthcheck
4 participants
@aratik711 @reimda @Hipska @MyaLongmire