fix: ensure aliyuncms metrics accept array, fix discovery #10850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the aliyuncms plugin was not correctly parsing metrics with multiple dimensions. This was due to some bad if/else logic. Once fixed users can do the following in their config:
Second, the plugin can do some auto-discovery of the JSON response that is received and then determine how to parse the response. However, it appears that aliyun/alibaba has updated some of the responses. This adds a
responseRootKey
rather than trying to determine that as the logic was not correct and no longer consistent across services. We already have a hard-codedresponseObjectIDKey
that is used as part of that root key.Finally, this updates the aliyun SDK.
Fixes: #10848