Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update parsing logic of config.Duration #10803

Merged
merged 2 commits into from
Mar 11, 2022
Merged

fix: update parsing logic of config.Duration #10803

merged 2 commits into from
Mar 11, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 10, 2022

Fixes: #10734

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 10, 2022
@Hipska Hipska added area/configuration ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Mar 10, 2022
sspaink
sspaink suggested changes Mar 10, 2022
View reviewed changes
config/types.go Show resolved Hide resolved
config/types.go Show resolved Hide resolved
config/types_test.go Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit 1560346 into influxdata:master Mar 11, 2022
@powersj powersj deleted the fix/precision-units branch March 11, 2022 15:15
@pichlermarc pichlermarc mentioned this pull request Mar 14, 2022
Closed
powersj added a commit to powersj/telegraf that referenced this pull request Mar 14, 2022
@powersj
fix: update the precision parameter default value
516d6c5 
In influxdata#10803, precision parsing was made more strict so that incorrect
values would be caught. The default precision value however is not
correct as an empty string.

fixes: influxdata#10813
@powersj powersj mentioned this pull request Mar 14, 2022
Merged
powersj added a commit to powersj/telegraf that referenced this pull request Mar 14, 2022
@powersj
fix: update the precision parameter default value
9fa8210 
In influxdata#10803, precision parsing was made more strict so that incorrect
values would be caught. The default precision value however is not
correct as an empty string, but will still accept the emptry string.

fixes: influxdata#10813
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
@powersj @MyaLongmire
fix: update parsing logic of config.Duration (#10803)
c40190c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspaink sspaink sspaink approved these changes

@Hipska Hipska Hipska approved these changes

Assignees
No one assigned
Labels
area/configuration fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telegraf precision parameter parsing in agent configuration
3 participants
@powersj @Hipska @sspaink