-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix handling of imports in protocol-buffer definitions #10798
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions about the paths, and then this is good to go!
Thank you or jumping on this!
Hey! This bug occurs on our end as well, any ETA for a merge ? |
Thanks! :) |
resolves #10794
Currently, the XPath parser fails when confronted with protocol-buffer definitions that import other definitions and are not in the current working directory. To solve the issue, we add a new option (
xpath_protobuf_import_paths
) to allow the user to specify import paths that are used to look up specified and imported definitions. If, for example, you do have filesA.proto
andB.proto
within a packagefoo
that are located in/data/my_proto/files
you can useto specify the required information to the parser.