feat: enrich AWS CW metrics with additional tags #10699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new plugin `aws_tags` copied from the existing `aws_ec2` plugins, excluding the instance identity logic. It includes a tag cache which contains the majority of the logic so it can easily be moved around.
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
the
feat
|
!signed-cla |
|
@maxmoehl looks like there are outstanding unit test and linter issues, could you resolve these please? Thank you! |
sspaink
added
waiting for response
|
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new plugin
aws_tagscopied from the existingaws_ec2plugins,excluding the instance identity logic. It includes a tag cache which
contains the majority of the logic so it can easily be moved around.
Required for all PRs:
resolves #10639
Most of the details are in the issue. Since I didn't get feedback there I'm opening this PR to start a discussion around this.
My main question is whether this functionality should be a standalone plugin or integrated into the CloudWatch plugin?