Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In Lustre input plugin, support collecting per-client stats. #10607

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

omgold
Copy link
Contributor

@omgold omgold commented Feb 9, 2022

Required for all PRs:

When reading stats from files /proc/fs/lustre/<target_type>/<target_name>/exports/<client_nid>/stats
previously the target was not tagged, but the client NID was tagged as 'name' and the metrics
from multiple targets were also 'mixed up' (not aggregated).
With this fix, the target name will be tagged as 'name' and the client NID will be tagged as 'client'.

The code detects whether there is an '/exports/' directory in the stat file path,
and will create the tags correctly in that case.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 9, 2022
When reading stats from files /proc/fs/lustre/<target_type>/<target_name>/exports/<client_nid>/stats
the client NID will be tagged as 'client'.
@Hipska Hipska added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants