feat: Bump github.com/aerospike/aerospike-client-go from 1.27.0 to 5.7.0 #10604
Conversation
sspaink
added
the
ready for final review
powersj
changed the title
|
Hi, Looking through this, I only had one question from your initial PR description:
Is this the reason for all the changes from |
|
@powersj Here For every node it currently returns the same host:port given in the config, ideally it should return the host:port of the node for which we are sending the metrics for. Shouldn't it send the host:port of the node it is fetching the metrics from? |
Yes, that change is correct. However, are you also changing the format of the node + port to node name? |
|
@powersj as per the README as well |
| func (a *Aerospike) getNodeInfo(n *as.Node) (map[string]string, error) { | ||
| stats, err := as.RequestNodeStats(n) | ||
| func (a *Aerospike) getNodeInfo(n *as.Node, infoPolicy *as.InfoPolicy) (map[string]string, error) { | ||
| stats, err := n.RequestInfo(infoPolicy) |
There was a problem hiding this comment.
Hi, I know it's a little late, but I think this has introduced a bug. Shouldn't this be added to this method call?
| stats, err := n.RequestInfo(infoPolicy) | |
| stats, err := n.RequestInfo(infoPolicy, "statistics") |
There was a problem hiding this comment.
@Hipska Thanks, Let me quickly test it out and create a PR
| @@ -465,6 +466,8 @@ func parseAerospikeValue(key string, v string) interface{} { | |||
| return parsed | |||
| } else if parsed, err := strconv.ParseBool(v); err == nil { | |||
| return parsed | |||
| } else if parsed, err := strconv.ParseFloat(v, 32); err == nil { | |||
Required for all PRs:
resolves #10315
The changes are listed below:
enable_ssloption would no longer be available.tls_name, which should be set to the value oftls-nameundertls{}stanza in the aerospike.conf if present.node_nametag to return Node.GetName() which now correctly returns node name, instead of the host:port which was incorrect.