-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove verbose logging from disk input plugin #10527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @reimda thanks for looking into this!
I would love to see set
becoming an internal
package as it is helpful in many places/plugins. Furthermore, we maybe should limit the error messages to be printed only once? We can use the set
again or remove the erroneous mountpoints from the set of processed ones...
What do you think?
@reimda there are some tests failing and they seem to be related... Can you please take a look? |
@reimda any chance you take a look at the tests? |
I'm struggling to find how this change causes the failures. I can reproduce them locally but I haven't gotten to the bottom of them yet. Still working on it! |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @reimda!
fixes #10514