Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Histogram aggregator metric expiration #10520

Merged
merged 1 commit into from
Feb 3, 2022
Merged

feat: Histogram aggregator metric expiration #10520

merged 1 commit into from
Feb 3, 2022

Conversation

opengamer29
Copy link
Contributor

Required for all PRs:

resolves #10517

Add an expiration_interval to aggregator histogram config. Setting this property allows deleting from cache outdated histogram older than expiration_interval.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 25, 2022
@opengamer29 opengamer29 force-pushed the feat/histogram_aggregator_expiration_time branch from 8581517 to fc255f8 Compare January 25, 2022 16:08
sspaink
sspaink approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@sspaink sspaink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you for the associated issue explaining your problem, gathering metrics from mobile devices sounds like an interesting setup.

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 25, 2022
srebhan
srebhan reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opengamer29, thanks for the nice PR. I have some smaller comments, can you please take a look?

plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Jan 26, 2022
@opengamer29 opengamer29 force-pushed the feat/histogram_aggregator_expiration_time branch 2 times, most recently from 49c4484 to 854a560 Compare January 28, 2022 15:16
@opengamer29
Copy link
Contributor Author

Sorry for bothering you here, but would you please also take attention to that issue and PR. I've tested the build with this feature request and that fix for our use case (collection mobile performance metrics). It significantly increased telegraf performance without any harm to the data quality on our graphs.

srebhan
srebhan reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments @opengamer29... Sorry for not having them in the first place....

plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
@opengamer29 opengamer29 force-pushed the feat/histogram_aggregator_expiration_time branch from 854a560 to c549fc0 Compare February 2, 2022 10:32
@opengamer29
Copy link
Contributor Author

Some more comments @opengamer29... Sorry for not having them in the first place....

Thanks for the detailed review. It's my first GoLang MR, so it's very helpful.

@opengamer29 opengamer29 force-pushed the feat/histogram_aggregator_expiration_time branch from c549fc0 to 99b9fa5 Compare February 2, 2022 10:55
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 2, 2022

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update @opengamer29! Additionally to the open comment above, I wanted to make you aware of a behavior change with your code. If that is fine, please mark the comment as resolved...

plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
@opengamer29 opengamer29 force-pushed the feat/histogram_aggregator_expiration_time branch from 99b9fa5 to a07c69c Compare February 3, 2022 08:26
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 3, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Awesome work @opengamer29!

@srebhan srebhan added plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 3, 2022
@srebhan srebhan requested a review from sspaink February 3, 2022 20:52
@powersj
Copy link
Contributor

powersj commented Feb 3, 2022

We missed updating the README, but I added it in #10583

@powersj powersj merged commit 5b58d0d into influxdata:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

@sspaink sspaink Awaiting requested review from sspaink

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Histogram aggregator metric expiration
4 participants
@opengamer29 @powersj @sspaink @srebhan