fix(outputs/amqp): Close the last connection when writing error to avoid connection leaks #10360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
approved these changes
Jan 4, 2022
| @@ -260,6 +260,9 @@ func (q *AMQP) Write(metrics []telegraf.Metric) error { | |||
| return err | |||
| } | |||
| } else { | |||
| if err := q.client.Close(); err != nil { | |||
| q.Log.Errorf("Closing connection failed: %v", err) | |||
| } | |||
| q.client = nil | |||
There was a problem hiding this comment.
Thanks for this - the GitHub diff looks weird, but this does look good to close the connection on the 2nd and additional publish attempts.
powersj
added
the
ready for final review
|
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
powersj
pushed a commit
to powersj/telegraf
that referenced
this pull request
Jan 21, 2022
…oid connection leaks (influxdata#10360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
When writing errors, such as occasional writing timeouts, close the last connection to avoid connection leaks.