-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Proxmox input: Changed VM ID from string to int, fixes #9611 #10068
Conversation
- Updated the VMStat schema to use a Number for ID. - Changed getCurrentVMStatus and getVmConfig accordingly. - Added case to testdata to check that both string representations and integers work in JSON.
0073aa4
to
5504485
Compare
@rare-magma, Finally found some time for this, continuing here... |
@srebhan With regards to your comment (originially on #9820):
To be honest I'm not sure: I experienced this bug when upgrading to Proxmox 7.0.0, so I expect it to be related to a change on their API. |
😄 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
@atetevoortwis the code looks good so far. Can you please check the documentation to make sure previous IDs were struct numerical and not |
As far as I know Proxmox VM ID's always have been integers: https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/lxc/{vmid} . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, assuming the backward compatibility is given as discussed. Thanks @atetevoortwis for your work!
Thanks @atetevoortwis |
(cherry picked from commit 8a3ba85)
Small fix to properly parse JSON data from Proxmox >=7.0 installs.
Required for all PRs:
resolves #9611