Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response content length to the http_response plugin #6037

Closed
aikdog opened this issue Jun 24, 2019 · 2 comments · Fixed by #6261
Closed

Add response content length to the http_response plugin #6037

aikdog opened this issue Jun 24, 2019 · 2 comments · Fixed by #6261
Labels
feature request Requests for new plugin and for new features to existing plugins good first issue This is a smaller issue suited for getting started in Telegraf, Golang, and contributing to OSS.
Milestone
1.12.0

Comments

@aikdog
Copy link

aikdog commented Jun 24, 2019

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

I ask in the http_request plugin to add the page size (like len (body))
@timhallinflux timhallinflux added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 24, 2019
@danielnelson
Copy link
Contributor

I'm assuming you meant the http_response input plugin? I think it would make sense to add a content_length field.

@danielnelson danielnelson added feature request Requests for new plugin and for new features to existing plugins and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 25, 2019
@danielnelson danielnelson changed the title http_request Add response content length to the http_response plugin Jun 25, 2019
@aikdog
Copy link
Author

aikdog commented Jun 26, 2019

Thnx!

@glinton glinton added the good first issue This is a smaller issue suited for getting started in Telegraf, Golang, and contributing to OSS. label Jun 27, 2019
invine added a commit to invine/telegraf that referenced this issue Aug 15, 2019
@invine
Add content_length metric to http_response input plugin (influxdata#6037
88bc9bb 
)
@invine invine mentioned this issue Aug 15, 2019
Merged
3 tasks
invine added a commit to invine/telegraf that referenced this issue Aug 15, 2019
@invine
Add content_length metric to http_response input plugin (influxdata#6037
023b5fc 
)
@danielnelson danielnelson added this to the 1.12.0 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins good first issue This is a smaller issue suited for getting started in Telegraf, Golang, and contributing to OSS.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Add content_length metric to http_response input plugin (#6037) invine/telegraf
4 participants
@danielnelson @glinton @timhallinflux @aikdog