Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out service inputs to an own subdirectory/section #11418

Closed
srebhan opened this issue Jun 29, 2022 · 4 comments
Closed

Factor out service inputs to an own subdirectory/section #11418

srebhan opened this issue Jun 29, 2022 · 4 comments
Labels
feature request Requests for new plugin and for new features to existing plugins size/m 2-4 day effort

Comments

@srebhan
Copy link
Member

srebhan commented Jun 29, 2022

Feature Request

Currently, gathering input plugins and service input plugins (aka listeners) are mixed in the plugins/inputs subdirectory and subsequently share the same TOML prefix. As the naming convention of appending _listener is both bulky and not always followed :-) it is sometimes impossible to tell them apart without looking to the code.

Proposal:

Move all listener/service input plugins to a new subdir plugins/serviceinputs and also change the TOML section to reflect the change. This way it is easier to know what to expect in both editing/reading the config and reviewing code.

Current behavior:

Inputs and service-inputs are mixed.

Desired behavior:

Clearly be able to tell apart both categories without looking at the code.

@srebhan srebhan added the feature request Requests for new plugin and for new features to existing plugins label Jun 29, 2022
@powersj
Copy link
Contributor

powersj commented Jun 30, 2022

next steps: talk to the team about this and decide to do this now vs in 2.0 as a breaking change as a part of #9478

@powersj powersj added the size/m 2-4 day effort label Jun 30, 2022
@Hipska
Copy link
Contributor

Hipska commented Jul 7, 2022

As a con, users will now need to look into 2 lists to find a plugin they need or want to use.

@srebhan
Copy link
Member Author

srebhan commented Jul 7, 2022

We could still generate a list where both types are on one page...

@srebhan
Copy link
Member Author

srebhan commented Feb 2, 2023

Closing this as we won't get to it in a foreseeable future...

@srebhan srebhan closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins size/m 2-4 day effort
Projects
None yet
Development

No branches or pull requests

3 participants